[Cairo] Add ERC1155Supply to 4.0.0-alpha.0 #765
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Comment |
| @@ -1,5 +1,12 @@ | |||
| # Changelog | |||
|
|
|||
| ## 3.1.0 (Unreleased) | |||
There was a problem hiding this comment.
This says 3.1.0 but packages/core/cairo_alpha/package.json says 4.0.0-alpha.0 (the same occurs in the other PRs)
There was a problem hiding this comment.
Oh, I updated because I remembered you mentioned at some point that wizard releases and the version of the contracts library were not pegged, and also the rest of this file follow the format of not using alphas. We still need alpha in the package.json version because that is used in the alpha switch in the UI, right?
There was a problem hiding this comment.
Right, the versions don't need to be pegged, but using Contracts for Cairo v4 is a breaking change.
We can just leave this line as
| ## 3.1.0 (Unreleased) | |
| ## Unreleased |
More detailed explanation (we should document this process):
The alpha switch label uses contractsVersionTag from packages/core/cairo_alpha/src/utils/version.ts.
All packages use changesets, except for cairo_alpha (which is excluded from the NPM release process, so we manually keep track of changes in its CHANGELOG.md. Those entries need to be manually moved into a changeset when we eventually promote it from alpha to stable for release).
When we merge/promote alpha to stable, we'll need to do the following in the resulting PR:
- Move the contents of
## Unreleasedsection to a changeset (new .md file under.changeset), targeting a major version bump of@openzeppelin/wizard-cairo - Ensure the version of
packages/core/cairo/package.jsonis NOT bumped manually (e.g. it must remain 3.x when we want to release 4.0.0) - The version packages workflow (prior to release) will: consume the changeset, move it to
packages/core/cairo/CHANGELOG.md, and update the version inpackages/core/cairo/package.json
No description provided.